englefly commented on code in PR #45958:
URL: https://github.com/apache/doris/pull/45958#discussion_r1901635316
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpJoinFromUnionAll.java:
##########
@@ -586,10 +586,17 @@ boolean comparePlan(Plan plan1, Plan plan2) {
isEqual = false;
}
for (int i = 0; isEqual && i < plan2.getOutput().size(); i++) {
- NamedExpression expr = ((LogicalProject<?>)
plan1).getProjects().get(i);
- NamedExpression replacedExpr = (NamedExpression)
- expr.rewriteUp(e -> plan1ToPlan2.getOrDefault(e,
e));
- if (!replacedExpr.equals(((LogicalProject<?>)
plan2).getProjects().get(i))) {
+ Expression expr1 = ((LogicalProject<?>)
plan1).getProjects().get(i);
Review Comment:
yes. tpcds q4. This is double checked by @feiniaofeiafei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
