yujun777 commented on code in PR #46303:
URL: https://github.com/apache/doris/pull/46303#discussion_r1903841602
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/RangeInference.java:
##########
@@ -154,7 +155,11 @@ private ValueDesc simplify(ExpressionRewriteContext
context,
List<ValueDesc> valuePerRefs = Lists.newArrayList();
for (Entry<Expression, Collection<ValueDesc>> referenceValues :
groupByReference.asMap().entrySet()) {
+ Expression reference = referenceValues.getKey();
List<ValueDesc> valuePerReference = (List)
referenceValues.getValue();
+ if (!isAnd) {
+ valuePerReference = ValueDesc.unionDiscreteAndRange(context,
reference, valuePerReference);
Review Comment:
this union values are belong to the same reference. For production sql, may
be it's hard to have 10k disjunction for one reference ?
what's more, the unionDiscreteAndRange's complexity should be O(N * logN)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
