morningman commented on PR #46492: URL: https://github.com/apache/doris/pull/46492#issuecomment-2574356464
This pull request includes several changes to the codebase, primarily focusing on removing deprecated methods and classes, as well as cleaning up unnecessary code. The most important changes are grouped by theme below: ### Code Cleanup: * Removed unnecessary `transmit_data` and related methods from `BaseBackendService` and `PInternalService` classes (`be/src/service/backend_service.cpp`, `be/src/service/internal_service.cpp`, `be/src/service/backend_service.h`, `be/src/service/internal_service.h`). [[1]](diffhunk://#diff-06d006ba29b358d37d062f658a42ea28b91ea9f8b790e11bd83e3d4737da7d5dL657-L697) [[2]](diffhunk://#diff-340767514ba294486bb425ff46a08febd0e2a7fda8866a7e0bed017d77647024L275-L289) [[3]](diffhunk://#diff-ea46691fad998c1aca17cb2959fd03a5896bd106487288074edf07abbb3cbb61L95-L96) [[4]](diffhunk://#diff-fc6955f6b96f775e061ef8241bdb1cdcfe418aca74f1c28894988b784c84074bL67-L76) [[5]](diffhunk://#diff-fc6955f6b96f775e061ef8241bdb1cdcfe418aca74f1c28894988b784c84074bL256-L260) * Removed unused `TDescribeTableParams` and `TDescribeTableResult` classes from various files (`be/src/exec/schema_scanner/schema_helper.cpp`, `be/src/exec/schema_scanner/schema_helper.h`, `fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java`). [[1]](diffhunk://#diff-5e981419741345f8575262c41f79b18b29d873b2197d73cf7c80f9f6591e8e1cL26-L27) [[2]](diffhunk://#diff-5a0afa80c291968413b2b63b96c15f2ee03ffac471e42371a958a8b898328b83L27-L28) [[3]](diffhunk://#diff-05d63be1d1350fe3cad8ce1a12aa07b86595052bd430521521e7232c6013f697L143-L144) [[4]](diffhunk://#diff-05d63be1d1350fe3cad8ce1a12aa07b86595052bd430521521e7232c6013f697L827-L894) * Removed the `describeTable` method from `FrontendServiceImpl` class (`fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java`). ### Deprecated Code Removal: * Removed the `TRowBatch` struct from `Data.thrift` file (`gensrc/thrift/Data.thrift`). * Removed `transmit_data` and `transmit_data_by_http` RPC definitions from `internal_service.proto` and `BackendService.thrift` files (`gensrc/proto/internal_service.proto`, `gensrc/thrift/BackendService.thrift`). [[1]](diffhunk://#diff-71a474c4ef6a9595175e7a55fdae2c9f439d952ebb1c4a9cc109e62b44daf67eL993-L994) [[2]](diffhunk://#diff-fb2c9eff75f722b9c12ba9b794668bb1f2f58f6d1a85b7125926188404f261a8L360-L364) ### Minor Changes: * Updated comments to remove references to deprecated methods and classes (`be/src/common/config.h`, `fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java`). [[1]](diffhunk://#diff-46e8c1ada0d43acf8c2965e46e90909089aada1f46531976c10605b837f8da3dL589-R589) [[2]](diffhunk://#diff-1065d3f88b9a3b4bb8f151cac8514ebd39085c9dc2f0081b0eec43fd67ad7b74L191) * Removed an unused function declaration from `debug_util.h` file (`be/src/util/debug_util.h`). * Cleaned up the `open` method in `SchemaScanOperatorX` class by removing commented-out code (`be/src/pipeline/exec/schema_scan_operator.cpp`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
