yiguolei commented on code in PR #46570:
URL: https://github.com/apache/doris/pull/46570#discussion_r1905695925
##########
be/src/olap/rowset/beta_rowset_reader.cpp:
##########
@@ -226,38 +226,49 @@ Status
BetaRowsetReader::get_segment_iterators(RowsetReaderContext* read_context
// When reader type is for query, session variable `enable_segment_cache`
should be respected.
bool should_use_cache = use_cache || (_read_context->reader_type ==
ReaderType::READER_QUERY &&
enable_segment_cache);
- SegmentCacheHandle segment_cache_handle;
- {
- SCOPED_RAW_TIMER(&_stats->rowset_reader_load_segments_timer_ns);
- RETURN_IF_ERROR(SegmentLoader::instance()->load_segments(
- _rowset, &segment_cache_handle, should_use_cache,
- /*need_load_pk_index_and_bf*/ false));
- }
-
- // create iterator for each segment
- auto& segments = segment_cache_handle.get_segments();
- _segments_rows.resize(segments.size());
- for (size_t i = 0; i < segments.size(); i++) {
- _segments_rows[i] = segments[i]->num_rows();
+ auto segment_count = _rowset->num_segments();
+ std::vector<segment_v2::SegmentSharedPtr> segments(segment_count);
+ auto [seg_start, seg_end] = _segment_offsets;
+ if (seg_start == seg_end) {
+ seg_start = 0;
+ seg_end = segment_count;
}
if (_read_context->record_rowids) {
+ _segments_rows.resize(segment_count);
+ {
+ SCOPED_RAW_TIMER(&_stats->rowset_reader_load_segments_timer_ns);
+ for (int64_t i = 0; i != segment_count; ++i) {
+ SegmentCacheHandle segment_cache_handle;
+ RETURN_IF_ERROR(SegmentLoader::instance()->load_segment(
+ _rowset, i, &segment_cache_handle, should_use_cache,
+ /*need_load_pk_index_and_bf*/ false));
+ const auto& tmp_segments = segment_cache_handle.get_segments();
+ _segments_rows[i] = tmp_segments[0]->num_rows();
+ if (i >= seg_start && i < seg_end) {
+ segments[i] = tmp_segments[0];
+ }
+ }
+ }
+
// init segment rowid map for rowid conversion
- std::vector<uint32_t> segment_num_rows;
- RETURN_IF_ERROR(get_segment_num_rows(&segment_num_rows));
RETURN_IF_ERROR(_read_context->rowid_conversion->init_segment_map(rowset()->rowset_id(),
-
segment_num_rows));
- }
-
- auto [seg_start, seg_end] = _segment_offsets;
- if (seg_start == seg_end) {
- seg_start = 0;
- seg_end = segments.size();
+
_segments_rows));
Review Comment:
should also check rowid_conversion != nullptr, to avoid core
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
