gavinchou opened a new pull request, #46657:
URL: https://github.com/apache/doris/pull/46657
### What problem does this PR solve?
we should read the recycle_rowset_key before removing to make KV txn
serializable.
Test case (hard to make it a regression)
```
mysql -h127.0.0.1 -P8952 -uroot -Ddb1 -e 'drop table if exists t1'
mysql -h127.0.0.1 -P8952 -uroot -Ddb1 -e 'CREATE TABLE t1 (id int, name
text, score text) ENGINE=OLAP DUPLICATE KEY(id) DISTRIBUTED BY HASH(id) BUCKETS
1'
curl -XPOST "localhost:7211/api/update_config?disable_auto_compaction=true"
curl
"localhost:6000/MetaService/http/v1/injection_point?token=greedisgood9999&op=disable"
curl
"localhost:6000/MetaService/http/v1/injection_point?token=greedisgood9999&op=clear"
for i in $(seq 1 1 100); do
mysql -h127.0.0.1 -P8952 -uroot -Ddb1 -e 'insert into t1 values(1,1,1)'
done
curl
"localhost:6000/MetaService/http/v1/injection_point?token=greedisgood9999&op=apply_suite&name=sleep_before_execute_commit_rowset"
curl
"localhost:6000/MetaService/http/v1/injection_point?token=greedisgood9999&op=enable"
curl -XPOST "localhost:7211/api/update_config?disable_auto_compaction=false"
sleep 60
instance_id=gavin_debug_instance_doris
tablet_id=$(mysql -h127.0.0.1 -P8952 -uroot -Ddb1 -e 'show tablets from t1;'
| awk '{if (++n>1) print $1}')
curl "localhost:7211/api/compaction/show?tablet_id=${tablet_id}"
txn_id=$(curl -s
"localhost:6000/MetaService/http/get_value?token=greedisgood9999&unicode&key_type=MetaRowsetKey&instance_id=${instance_id}&tablet_id=${tablet_id}&version=101"
| jq ".txn_id" | tr -d '"')
curl -s
"localhost:6000/MetaService/http/get_value?token=greedisgood9999&unicode&key_type=MetaRowsetTmpKey&instance_id=${instance_id}&tablet_id=${tablet_id}&txn_id=${txn_id}"
```
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [x] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]