zgxme commented on code in PR #46767:
URL: https://github.com/apache/doris/pull/46767#discussion_r1923000253
##########
docker/thirdparties/docker-compose/hive/scripts/hive-metastore.sh:
##########
@@ -163,6 +163,4 @@ echo "Script: create_view.hql executed in ${EXECUTION_TIME}
seconds"
touch /mnt/SUCCESS
# Avoid container exit
-while true; do
- sleep 1
-done
+tail -f /dev/null
Review Comment:
rebase master and modify hear
e.g.
https://github.com/apache/doris/blob/3943076fda89e6dcb1a204792cd331b066dcca8f/docker/thirdparties/docker-compose/kerberos/entrypoint-hive-master.sh#L74
and modify hive healthy check
##########
docker/thirdparties/docker-compose/iceberg/iceberg.yaml.tpl:
##########
@@ -83,12 +83,22 @@ services:
networks:
- doris--iceberg
entrypoint: /bin/bash /mnt/data/input/script/rest_init.sh
+ healthcheck:
+ test: ["CMD", "curl", --fail", "http://localhost:8181/v1/config";]
+ interval: 10s
+ timeout: 60s
+ retries: 30
minio:
image: minio/minio
container_name: doris--minio
ports:
- ${MINIO_API_PORT}:9000
+ healthcheck:
Review Comment:
need modify `run-thirdparties-docker.sh`
```
sudo docker compose -f "${ROOT}"/docker-compose/iceberg/iceberg.yaml
--env-file "${ROOT}"/docker-compose/iceberg/iceberg.env up -d --wait
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
