suxiaogang223 commented on code in PR #45881:
URL: https://github.com/apache/doris/pull/45881#discussion_r1926760890
##########
be/src/vec/exec/format/table/transactional_hive_reader.h:
##########
@@ -57,15 +55,15 @@ class TransactionalHiveReader : public TableFormatReader {
public:
struct AcidRowID {
int64_t original_transaction;
- int32_t bucket;
+ int64_t bucket;
int64_t row_id;
struct Hash {
size_t operator()(const AcidRowID& transactional_row_id) const {
size_t hash_value = 0;
hash_value ^= std::hash<int64_t>
{}(transactional_row_id.original_transaction) +
0x9e3779b9 + (hash_value << 6) + (hash_value >>
2);
- hash_value ^= std::hash<int32_t>
{}(transactional_row_id.bucket) + 0x9e3779b9 +
+ hash_value ^= std::hash<int64_t>
{}(transactional_row_id.bucket) + 0x9e3779b9 +
Review Comment:
`std::hash<T>` will return size_t whenever waht `T` is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
