gavinchou commented on code in PR #47473:
URL: https://github.com/apache/doris/pull/47473#discussion_r1938524973
##########
be/src/io/cache/block_file_cache.h:
##########
@@ -186,6 +189,9 @@ class BlockFileCache {
bool try_reserve(const UInt128Wrapper& hash, const CacheContext& context,
size_t offset,
size_t size, std::lock_guard<std::mutex>& cache_lock);
+ // async evict when water mark is reached, unlike try_reserve, removal is
done in background
+ void try_evict_in_advance(size_t size, std::lock_guard<std::mutex>&
cache_lock);
Review Comment:
add detailed comment what is the water mark, what is the behavor/machanism
of this function, what is the assumption
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
