zhannngchen commented on code in PR #47766:
URL: https://github.com/apache/doris/pull/47766#discussion_r1951938932
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -2381,28 +2387,49 @@ void MetaServiceImpl::remove_delete_bitmap_update_lock(
msg = "failed to init txn";
return;
}
- if (!check_delete_bitmap_lock(code, msg, ss, txn, instance_id,
request->table_id(),
- request->lock_id(), request->initiator())) {
+ std::string lock_key =
+ meta_delete_bitmap_update_lock_key({instance_id,
request->table_id(), -1});
+ std::string lock_val;
+ DeleteBitmapUpdateLockPB lock_info;
+ if (!check_delete_bitmap_lock(code, msg, ss, txn, request->table_id(),
request->lock_id(),
+ request->initiator(), lock_key, lock_info)) {
LOG(WARNING) << "failed to check delete bitmap tablet lock"
<< " table_id=" << request->table_id() << " tablet_id="
<< request->tablet_id()
<< " request lock_id=" << request->lock_id()
<< " request initiator=" << request->initiator() << " msg
" << msg;
return;
}
- std::string lock_key =
- meta_delete_bitmap_update_lock_key({instance_id,
request->table_id(), -1});
- txn->remove(lock_key);
+ auto initiators = lock_info.mutable_initiators();
Review Comment:
if it's not the owner of the lock, return directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
