yiguolei commented on code in PR #47784:
URL: https://github.com/apache/doris/pull/47784#discussion_r1952034815
##########
be/src/runtime/runtime_query_statistics_mgr.cpp:
##########
@@ -466,73 +450,56 @@ void
RuntimeQueryStatisticsMgr::report_runtime_query_statistics() {
void RuntimeQueryStatisticsMgr::set_query_finished(std::string query_id) {
// NOTE: here must be a write lock
- std::lock_guard<std::shared_mutex> write_lock(_qs_ctx_map_lock);
+ std::lock_guard<std::shared_mutex> write_lock(_resource_contexts_map_lock);
// when a query get query_ctx succ, but failed before create node/operator,
- // it may not register query statistics, so it can not be mark finish
Review Comment:
这个方法还有用吗？ 直接query context 析构的时候修改resource context 就可以了吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
