xy720 commented on code in PR #47300:
URL: https://github.com/apache/doris/pull/47300#discussion_r1957282702
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Partition.java:
##########
@@ -350,6 +351,11 @@ public boolean visualiseShadowIndex(long shadowIndexId,
boolean isBaseIndex) {
@Deprecated
public static Partition read(DataInput in) throws IOException {
+ if (Env.getCurrentEnvJournalVersion() <= FeMetaVersion.VERSION_129) {
+ Partition partition = new Partition();
+ partition.readFields(in);
+ return partition;
+ }
Review Comment:
Restore job need to read BackupMeta from a file, which is downloaded from
repo into a temp dir in FE.
When reading, it specifies the meta version, which is used on the backup
doris cluster.
From example,
we backup data from a 2.1 doris, which meta version is lower or equal than
129.
Then we restore data to a 3.0 cloud doris,
In cloud mode, EnvFactory.getInstance().createPartition() will create a
CloudPartition,
this will causes the read function failed.
If we found the meta version here is lower the 129, which means it is
absolutely should not return a CloudPartition, We can return a Partition here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
