morrySnow commented on code in PR #47929:
URL: https://github.com/apache/doris/pull/47929#discussion_r1958123075
##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/BaseTableInfo.java:
##########
@@ -171,7 +171,11 @@ public void compatible(CatalogMgr catalogMgr) {
this.dbName = db.getFullName();
this.tableName = table.getName();
} catch (AnalysisException e) {
- LOG.warn("MTMV compatible failed, ctlId: {}, dbId: {}, tableId:
{}", ctlId, dbId, tableId, e);
+ String msg = String.format(
+ "Failed to get name based on id during compatibility
process, ctlId: %s, dbId: %s, tableId: %s",
+ ctlId, dbId, tableId);
+ LOG.warn(msg, e);
+ throw new Exception(msg);
Review Comment:
maybe we should use return value, not throw exception. throw exception is
very expansive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
