dataroaring commented on code in PR #47300:
URL: https://github.com/apache/doris/pull/47300#discussion_r1959782547
##########
fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java:
##########
@@ -742,6 +745,13 @@ private void checkAndPrepareMeta() {
Partition remotePartition =
remoteOlapTbl.getPartition(partitionName);
if (localPartition != null) {
// Partition already exist.
+ if (Config.isCloudMode()) {
+ // cloud mode don't allow restoring on
existing partition now.
+ status = new Status(ErrCode.COMMON_ERROR,
"cloud mode don't allow restore"
+ + " on a exising partition now.
local table: " + localTbl.getName()
+ + " restore partition: " +
partitionName);
+ return;
+ }
Review Comment:
Need a case.
##########
fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java:
##########
@@ -734,6 +732,11 @@ private void checkAndPrepareMeta() {
return;
}
+ checkStorageVault(localOlapTbl);
+ if (!status.ok()) {
+ return;
Review Comment:
Need a case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
