yiguolei commented on code in PR #47979:
URL: https://github.com/apache/doris/pull/47979#discussion_r1960852935
##########
be/src/pipeline/exec/multi_cast_data_stream_sink.cpp:
##########
@@ -49,12 +49,9 @@ Status MultiCastDataStreamSinkOperatorX::sink(RuntimeState*
state, vectorized::B
COUNTER_UPDATE(local_state.rows_input_counter(),
(int64_t)in_block->rows());
if (in_block->rows() > 0 || eos) {
COUNTER_UPDATE(local_state.rows_input_counter(),
(int64_t)in_block->rows());
- auto st =
local_state._shared_state->multi_cast_data_streamer->push(state, in_block, eos);
- // TODO: improvement: if sink returned END_OF_FILE, pipeline task can
be finished
- if (st.template is<ErrorCode::END_OF_FILE>()) {
- return Status::OK();
- }
- return st;
+ // push block to multi cast data streamer , it will not return the EOF
status.
Review Comment:
不要做这种假定，完后调用的push 函数有eof的处理能力咋整
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
