SWJTU-ZhangLei commented on code in PR #10429:
URL: https://github.com/apache/doris/pull/10429#discussion_r908130329
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java:
##########
@@ -2463,10 +2463,12 @@ public void addFrontend(FrontendNodeType role, String
host, int editLogPort) thr
fe = new Frontend(role, nodeName, host, editLogPort);
frontends.put(nodeName, fe);
+ BDBHA bdbha = (BDBHA) haProtocol;
if (role == FrontendNodeType.FOLLOWER || role ==
FrontendNodeType.REPLICA) {
- ((BDBHA) getHaProtocol()).addHelperSocket(host, editLogPort);
+ bdbha.addHelperSocket(host, editLogPort);
Review Comment:
> Where does the conflict occur, and should we `removeConflictNodeIfExist`
and then `addHelperSocket`?
https://docs.oracle.com/cd/E17277_02/html/java/com/sleepycat/je/rep/util/ReplicationGroupAdmin.html#getHelperSockets--
when new node start successfuly, others can get admin service from helper
socket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
