morningman commented on code in PR #10484:
URL: https://github.com/apache/doris/pull/10484#discussion_r909233260
##########
gensrc/thrift/PaloInternalService.thrift:
##########
@@ -227,7 +227,7 @@ struct TPlanFragmentExecParams {
5: list<TPlanFragmentDestination> destinations
// Debug options: perform some action in a particular phase of a particular
node
- 6: optional Types.TPlanNodeId debug_node_id
+ // 6: optional Types.TPlanNodeId debug_node_id // Never used
Review Comment:
The following 2 fields can be removed too?
##########
be/src/exec/exec_node.cpp:
##########
@@ -772,24 +734,6 @@ void ExecNode::reached_limit(vectorized::Block* block,
bool* eos) {
COUNTER_SET(_rows_returned_counter, _num_rows_returned);
}
-/*
-Status ExecNode::enable_deny_reservation_debug_action() {
Review Comment:
Why not remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
