yinzhijian commented on code in PR #10415:
URL: https://github.com/apache/doris/pull/10415#discussion_r910757341
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/ExpressionConverter.java:
##########
@@ -44,19 +45,14 @@
* Used to convert expression of new optimizer to stale expr.
*/
@SuppressWarnings("rawtypes")
-public class ExpressionConverter extends ExpressionVisitor<Expr,
PlanTranslatorContext> {
+public class ExpressionConverter extends DefaultExpressionVisitor<Expr,
PlanTranslatorContext> {
public static ExpressionConverter converter = new ExpressionConverter();
public static Expr convert(Expression expression, PlanTranslatorContext
planContext) {
return converter.visit(expression, planContext);
Review Comment:
```suggestion
return expression.accept(converter, planContext);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
