Yulei-Yang commented on code in PR #40680:
URL: https://github.com/apache/doris/pull/40680#discussion_r1971207968
##########
fe/fe-core/src/main/java/org/apache/doris/binlog/BinlogManager.java:
##########
@@ -154,7 +154,11 @@ private void addBinlog(long dbId, List<Long> tableIds,
long commitSeq, long time
if (tableIds != null) {
for (long tableId : tableIds) {
boolean tableBinlogEnable =
binlogConfigCache.isEnableTable(dbId, tableId);
- anyEnable = anyEnable || tableBinlogEnable;
+ if (tableIds.size() > 1) {
+ anyEnable = anyEnable || tableBinlogEnable;
+ } else {
+ anyEnable = tableBinlogEnable;
+ }
Review Comment:
this code is used to ignore generating binlog for temporary table, coz
temporary table always has binlog.enable = false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
