liaoxin01 commented on code in PR #48209:
URL: https://github.com/apache/doris/pull/48209#discussion_r1973502061


##########
be/src/runtime/routine_load/routine_load_task_executor.cpp:
##########
@@ -78,15 +79,19 @@ RoutineLoadTaskExecutor::~RoutineLoadTaskExecutor() {
 
 Status RoutineLoadTaskExecutor::init(int64_t process_mem_limit) {
     _load_mem_limit = process_mem_limit * 
config::load_process_max_memory_limit_percent / 100;
-    return ThreadPoolBuilder("routine_load")
-            .set_min_threads(0)
-            .set_max_threads(config::max_routine_load_thread_pool_size)
-            .set_max_queue_size(config::max_routine_load_thread_pool_size)
-            .build(&_thread_pool);
+    RETURN_IF_ERROR(ThreadPoolBuilder("routine_load")
+                            .set_min_threads(0)
+                            
.set_max_threads(config::max_routine_load_thread_pool_size)
+                            
.set_max_queue_size(config::max_routine_load_thread_pool_size)
+                            .build(&_thread_pool));
+    REGISTER_HOOK_METRIC(routine_load_thread_num,

Review Comment:
   The metrics of thread pool has been added in pr #43144.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to