Yulei-Yang commented on code in PR #40680:
URL: https://github.com/apache/doris/pull/40680#discussion_r1978829193
##########
fe/fe-core/src/main/java/org/apache/doris/backup/BackupHandler.java:
##########
@@ -435,14 +436,27 @@ private void backup(Repository repository, Database db,
BackupStmt stmt) throws
if (Config.ignore_backup_not_support_table_type) {
LOG.warn("Table '{}' is a {} table, can not backup and
ignore it."
+ "Only OLAP(Doris)/ODBC/VIEW table can be backed
up",
- tblName, tbl.getType().toString());
+ tblName, tbl.isTemporary() ? "temporary" :
tbl.getType().toString());
tblRefsNotSupport.add(tblRef);
continue;
} else {
ErrorReport.reportDdlException(ErrorCode.ERR_NOT_OLAP_TABLE, tblName);
}
}
+ if (tbl.isTemporary()) {
+ if (Config.ignore_backup_not_support_table_type) {
+ LOG.warn("Table '{}' is a temporary table, can not backup
and ignore it."
+ + "Only OLAP(Doris)/ODBC/VIEW table can be backed
up",
+ Util.getTempTableDisplayName(tblName));
+ tblRefsNotSupport.add(tblRef);
+ continue;
+ } else {
+ ErrorReport.reportDdlException("Table " +
Util.getTempTableDisplayName(tblName)
Review Comment:
As discussed, if a backup job only contains one temporary table, will throw
error. While, if a backup job contains temporary table and other olap table,
will just ignore temporary table, and the backup job will run.
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
