eldenmoon commented on code in PR #48625:
URL: https://github.com/apache/doris/pull/48625#discussion_r1979087524
##########
be/src/vec/olap/olap_data_convertor.cpp:
##########
@@ -674,6 +677,11 @@ Status
OlapBlockDataConvertor::OlapColumnDataConvertorVarChar::convert_to_olap(
"Not support string len over than "
"`string_type_length_soft_limit_bytes` in vec
engine.");
}
+ // Make sure that the json binary data written in is the
correct jsonb value.
+ if (_is_jsonb &&
!doris::JsonbDocument::createDocument(slice->data, slice->size)) {
Review Comment:
get_type_id will call virtual function, which is slow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
