This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 3f6a7019101 branch-3.0: [improve](cloud)(transaction) do not execute
afterVisible if commit transaction fail in cloud mode #48576 (#48774)
3f6a7019101 is described below
commit 3f6a70191019b0d39e10c80216e09c4173ef7671
Author: github-actions[bot]
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Tue Mar 11 10:04:21 2025 +0800
branch-3.0: [improve](cloud)(transaction) do not execute afterVisible if
commit transaction fail in cloud mode #48576 (#48774)
Cherry-picked from #48576
Co-authored-by: hui lai <[email protected]>
---
.../apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java
b/fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java
index 188173b32a9..b473bf63a39 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java
@@ -615,7 +615,10 @@ public class CloudGlobalTransactionMgr implements
GlobalTransactionMgrIface {
LOG.info("commitTxn, run txn callback, transactionId:{}
callbackId:{}, txnState:{}",
transactionId, callbackId, txnState);
cb.afterCommitted(txnState, txnOperated);
- cb.afterVisible(txnState, txnOperated);
+ // do not exectue afterVisible if commit txn fail in cloud mode
+ if (txnOperated) {
+ cb.afterVisible(txnState, txnOperated);
+ }
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
