zhiqiang-hhhh commented on code in PR #48750:
URL: https://github.com/apache/doris/pull/48750#discussion_r1988641950
##########
be/src/util/threadpool.cpp:
##########
@@ -47,7 +47,9 @@
DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(thread_pool_max_queue_size, MetricUnit::NOUNI
DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(thread_pool_max_threads,
MetricUnit::NOUNIT);
DEFINE_COUNTER_METRIC_PROTOTYPE_2ARG(thread_pool_submit_failed,
MetricUnit::NOUNIT);
DEFINE_COUNTER_METRIC_PROTOTYPE_2ARG(task_execution_time_ns_total,
MetricUnit::NANOSECONDS);
Review Comment:
> thread pool 相关的监控，都要以thread_pool_ 开头，否则我们不知道这个task 是scan task，pipelinetask
还是啥。task 这种太通用了。 其他thread pool 相关的指标，也都改一下。趁着我们还没做grafana dashboard
知道的啊，thread_pool_监控有个字段标记它的线程池名字
`doris_be_thread_pool_active_threads {job="$be_cluster_id",
thread_pool_name="Scan_normal"}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
