This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new fe35304aa3e branch-2.1 [fix](nereids) avoid generate Runtime filter
whose target is not a base table column (#48779)
fe35304aa3e is described below
commit fe35304aa3ef3cd1dfb29112a4068223d1adf7c9
Author: minghong <[email protected]>
AuthorDate: Mon Mar 10 17:32:52 2025 +0800
branch-2.1 [fix](nereids) avoid generate Runtime filter whose target is not
a base table column (#48779)
### What problem does this PR solve?
pick #48804
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
---
.../nereids/processor/post/RuntimeFilterContext.java | 4 ++++
.../nereids/processor/post/RuntimeFilterGenerator.java | 16 ++++++++++++++++
2 files changed, 20 insertions(+)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterContext.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterContext.java
index 585ab5f3d7b..6e6643140f8 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterContext.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterContext.java
@@ -279,6 +279,10 @@ public class RuntimeFilterContext {
return aliasTransferMap.put(slot, pair);
}
+ public void aliasTransferMapRemove(NamedExpression slot) {
+ aliasTransferMap.remove(slot);
+ }
+
public boolean aliasTransferMapContains(NamedExpression slot) {
return aliasTransferMap.containsKey(slot);
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterGenerator.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterGenerator.java
index 57c322d030f..68fca97e7bf 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterGenerator.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterGenerator.java
@@ -37,6 +37,7 @@ import org.apache.doris.nereids.trees.expressions.Not;
import org.apache.doris.nereids.trees.expressions.Slot;
import org.apache.doris.nereids.trees.expressions.SlotReference;
import
org.apache.doris.nereids.trees.expressions.functions.scalar.BitmapContains;
+import org.apache.doris.nereids.trees.expressions.literal.Literal;
import org.apache.doris.nereids.trees.plans.AbstractPlan;
import org.apache.doris.nereids.trees.plans.JoinType;
import org.apache.doris.nereids.trees.plans.Plan;
@@ -440,6 +441,21 @@ public class RuntimeFilterGenerator extends
PlanPostProcessor {
if (expression.children().isEmpty()) {
continue;
}
+ /*
+ * join(#5=#6)
+ * -->project(null as #5)
+ * --> any
+ * -->project(#6)
+ * --->scan(T[#5, #6])
+ *
+ * both left tree and right tree contain exprId=5.
+ * remove #5 from alias map to avoid generate wrong rf
+ */
+ if (expression instanceof Alias && expression.child(0) instanceof
Literal) {
+ Alias alias = (Alias) expression;
+ ctx.aliasTransferMapRemove(alias.toSlot());
+ continue;
+ }
Expression expr =
ExpressionUtils.getSingleNumericSlotOrExpressionCoveredByCast(expression.child(0));
if (expr instanceof NamedExpression
&& ctx.aliasTransferMapContains((NamedExpression) expr)) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
