zhannngchen commented on code in PR #48968:
URL: https://github.com/apache/doris/pull/48968#discussion_r1991366317
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -935,6 +935,7 @@ void TabletMeta::delete_stale_rs_meta_by_version(const
Version& version) {
// remove rowset delete bitmap
delete_bitmap().remove({(*it)->rowset_id(), 0, 0},
{(*it)->rowset_id(), UINT32_MAX, 0});
+
delete_bitmap().remove_rowset_cache_version((*it)->rowset_id());
Review Comment:
Add a DCHECK at the end of the fucntion, to check that the size of
_rowset_cache_version is smaller than the size of `_rs_metas.size() +
_stale_rs_metas.size()` to avoid mem leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
