morrySnow commented on code in PR #49061:
URL: https://github.com/apache/doris/pull/49061#discussion_r1994685613
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/StringArithmetic.java:
##########
@@ -406,12 +406,8 @@ public static Expression characterLength(StringLikeLiteral
first) {
return new IntegerLiteral(first.getValue().length());
}
- private static boolean isSeparator(char c) {
- if (".$|()[{^?*+\\".indexOf(c) == -1) {
- return false;
- } else {
- return true;
- }
+ private static boolean isAlphabetic(char c) {
+ return String.valueOf(c).matches("[A-Za-z]");
Review Comment:
should consider such as `ÀÇ`, u should use `\P{L}`.
refer: https://www.regular-expressions.info/unicode.html#prop
notice, BE has bug when process UTF-8 in some functions, so should not
follow BE's behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
