yiguolei commented on code in PR #48924:
URL: https://github.com/apache/doris/pull/48924#discussion_r1994646559
##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -175,8 +175,7 @@ io::UInt128Wrapper Segment::file_cache_key(std::string_view
rowset_id, uint32_t
}
int64_t Segment::get_metadata_size() const {
- return sizeof(Segment) + (_footer_pb ? _footer_pb->ByteSizeLong() : 0) +
Review Comment:
是所有的footer pb 都在cache 里的，segment 对象彻底的不own pb 对象了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
