dataroaring commented on code in PR #49046:
URL: https://github.com/apache/doris/pull/49046#discussion_r1995083036
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -1875,8 +1876,13 @@ void
MetaServiceImpl::update_delete_bitmap(google::protobuf::RpcController* cont
return;
}
// 2. Process pending delete bitmap
- if (!process_pending_delete_bitmap(code, msg, ss, txn, instance_id,
tablet_id)) {
- return;
+
+ // if this is a txn load and is not the first sub txn, we should not
remove
+ // the pending delete bitmaps written by previous sub txns
+ if (!is_not_first_sub_txn) {
+ if (!process_pending_delete_bitmap(code, msg, ss, txn,
instance_id, tablet_id)) {
Review Comment:
remove_useless_delete_bitmap is a better name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]