morningman commented on code in PR #10620:
URL: https://github.com/apache/doris/pull/10620#discussion_r916803679
##########
fe/fe-core/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -1654,6 +1654,12 @@ public class Config extends ConfigBase {
@ConfField(mutable = false, masterOnly = true)
public static boolean enable_multi_catalog = false; // 1 min
+ @ConfField(mutable = true, masterOnly = true)
Review Comment:
Both `file_scan_node_spilt_size` and `file_scan_node_spilt_num` are NOT
`masterOnly` config.
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/ExternalFileScanNode.java:
##########
@@ -134,6 +135,30 @@ public int numBackends() {
}
}
+ private static class FileSpiltStrategy {
Review Comment:
```suggestion
private static class FileSplitStrategy {
```
And all other `split` typo.
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/ExternalFileScanNode.java:
##########
@@ -340,6 +380,7 @@ protected void toThrift(TPlanNode planNode) {
@Override
public List<TScanRangeLocations> getScanRangeLocations(long
maxScanRangeLength) {
+ LOG.info("There is {} scanRangeLocations for execution.",
scanRangeLocations.size());
Review Comment:
```suggestion
LOG.debug("There is {} scanRangeLocations for execution.",
scanRangeLocations.size());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
