morningman commented on code in PR #49238:
URL: https://github.com/apache/doris/pull/49238#discussion_r2009416219
##########
thirdparty/CHANGELOG.md:
##########
@@ -9,6 +9,7 @@ This file contains version of the third-party dependency
libraries in the build-
## 20250318
- Modified: hadoop-libs 3.3.6.5 -> 3.3.6.6
+- Added: pugixml 1.15, a C++ XML processing library.
Review Comment:
add a new entry
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1866,6 +1866,22 @@ build_jindofs() {
cp -r ${TP_SOURCE_DIR}/${JINDOFS_SOURCE}/*
"${TP_INSTALL_DIR}/jindofs_libs/"
}
+# pugixml
+build_pugixml() {
+ check_if_source_exist "${PUGIXML_SOURCE}"
+ cd "${TP_SOURCE_DIR}/${PUGIXML_SOURCE}"
+
+ rm -rf "${BUILD_DIR}"
+ mkdir -p "${BUILD_DIR}"
+ cd "${BUILD_DIR}"
+
+ "${CMAKE_CMD}" -G "${GENERATOR}"
-DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" -DCMAKE_BUILD_TYPE=Release ..
+ "${BUILD_SYSTEM}" -j "${PARALLEL}"
+ "${BUILD_SYSTEM}" install
+
+ cp -r "${TP_SOURCE_DIR}/${PUGIXML_SOURCE}/src"/*
"${TP_INSTALL_DIR}/include/"
Review Comment:
only hpp in enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
