This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new bf6923696de branch-3.0: [improve](thrift) Config
thrift_max_message_size for THREAD_POOL and … #49677 (#49722)
bf6923696de is described below
commit bf6923696de59c6441261fca9c171844b76bcbfc
Author: github-actions[bot]
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Wed Apr 2 11:07:50 2025 +0800
branch-3.0: [improve](thrift) Config thrift_max_message_size for
THREAD_POOL and … #49677 (#49722)
Cherry-picked from #49677
Co-authored-by: walter <[email protected]>
---
be/src/util/thrift_server.cpp | 27 +++++++++++++++++++++++----
1 file changed, 23 insertions(+), 4 deletions(-)
diff --git a/be/src/util/thrift_server.cpp b/be/src/util/thrift_server.cpp
index d5ce48e6781..df75ba486dd 100644
--- a/be/src/util/thrift_server.cpp
+++ b/be/src/util/thrift_server.cpp
@@ -82,6 +82,25 @@ private:
std::shared_ptr<TConfiguration> config;
};
+class ImprovedBufferedTransportFactory
+ : public apache::thrift::transport::TBufferedTransportFactory {
+ using TConfiguration = apache::thrift::TConfiguration;
+ using TTransport = apache::thrift::transport::TTransport;
+ using TBufferedTransport = apache::thrift::transport::TBufferedTransport;
+
+public:
+ ImprovedBufferedTransportFactory()
+ :
config(std::make_shared<TConfiguration>(config::thrift_max_message_size)) {}
+ ~ImprovedBufferedTransportFactory() override = default;
+
+ std::shared_ptr<TTransport> getTransport(std::shared_ptr<TTransport>
trans) override {
+ return std::make_shared<TBufferedTransport>(std::move(trans), config);
+ }
+
+private:
+ std::shared_ptr<TConfiguration> config;
+};
+
// Helper class that starts a server in a separate thread, and handles
// the inter-thread communication to monitor whether it started
// correctly.
@@ -337,8 +356,7 @@ Status ThriftServer::start() {
std::make_shared<apache::thrift::concurrency::ThreadFactory>();
std::shared_ptr<apache::thrift::transport::TServerTransport>
fe_server_transport;
std::shared_ptr<apache::thrift::transport::TTransportFactory>
transport_factory;
- std::shared_ptr<apache::thrift::transport::TNonblockingServerSocket>
socket =
- std::make_shared<ImprovedNonblockingServerSocket>(_port);
+ std::shared_ptr<apache::thrift::transport::TNonblockingServerSocket>
socket;
if (_server_type != THREADED) {
thread_mgr =
apache::thrift::concurrency::ThreadManager::newSimpleThreadManager(
_num_worker_threads);
@@ -352,6 +370,7 @@ Status ThriftServer::start() {
switch (_server_type) {
case NON_BLOCKING:
+ socket = std::make_shared<ImprovedNonblockingServerSocket>(_port);
if (transport_factory == nullptr) {
transport_factory.reset(new
apache::thrift::transport::TTransportFactory());
}
@@ -366,7 +385,7 @@ Status ThriftServer::start() {
BackendOptions::get_service_bind_address_without_bracket(),
_port));
if (transport_factory == nullptr) {
- transport_factory.reset(new
apache::thrift::transport::TBufferedTransportFactory());
+ transport_factory =
std::make_shared<ImprovedBufferedTransportFactory>();
}
_server = std::make_unique<apache::thrift::server::TThreadPoolServer>(
@@ -380,7 +399,7 @@ Status ThriftServer::start() {
server_socket->setKeepAlive(true);
if (transport_factory == nullptr) {
- transport_factory.reset(new
apache::thrift::transport::TBufferedTransportFactory());
+ transport_factory =
std::make_shared<ImprovedBufferedTransportFactory>();
}
_server = std::make_unique<apache::thrift::server::TThreadedServer>(
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
