Copilot commented on code in PR #49688:
URL: https://github.com/apache/doris/pull/49688#discussion_r2020640946
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/source/PaimonScanNode.java:
##########
@@ -276,6 +276,9 @@ public List<Split> getSplits(int numBackends) throws
UserException {
boolean applyCountPushdown = getPushDownAggNoGroupingOp() ==
TPushAggOp.COUNT;
// Just for counting the number of selected partitions for this paimon
table
Set<BinaryRow> selectedPartitionValues = Sets.newHashSet();
+ // if applyCountPushdown is true, we can't to split the file
+ // becasue the raw file and deletion vector is one-to-one mapping
Review Comment:
[nitpick] Typo in comment: 'becasue' should be corrected to 'because'.
```suggestion
// because the raw file and deletion vector is one-to-one mapping
```
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/source/PaimonScanNode.java:
##########
@@ -276,6 +276,9 @@ public List<Split> getSplits(int numBackends) throws
UserException {
boolean applyCountPushdown = getPushDownAggNoGroupingOp() ==
TPushAggOp.COUNT;
// Just for counting the number of selected partitions for this paimon
table
Set<BinaryRow> selectedPartitionValues = Sets.newHashSet();
+ // if applyCountPushdown is true, we can't to split the file
+ // becasue the raw file and deletion vector is one-to-one mapping
Review Comment:
[nitpick] In the comment, consider replacing 'can't to split' with 'cannot
split' for improved clarity.
```suggestion
// if applyCountPushdown is true, we cannot split the file
// because the raw file and deletion vector is one-to-one mapping
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
