morningman commented on code in PR #49688:
URL: https://github.com/apache/doris/pull/49688#discussion_r2036489109
##########
be/src/vec/exec/jni_connector.cpp:
##########
@@ -82,12 +90,15 @@ Status JniConnector::open(RuntimeState* state,
RuntimeProfile* profile) {
batch_size = _state->batch_size();
}
RETURN_IF_ERROR(JniUtil::GetJNIEnv(&env));
- SCOPED_TIMER(_open_scanner_time);
+ MonotonicStopWatch _watch;
Review Comment:
use MACRO, like this: `SCOPED_RAW_TIMER(&_statistics.decode_dict_time);`
##########
be/src/vec/exec/jni_connector.cpp:
##########
@@ -82,12 +90,15 @@ Status JniConnector::open(RuntimeState* state,
RuntimeProfile* profile) {
batch_size = _state->batch_size();
}
RETURN_IF_ERROR(JniUtil::GetJNIEnv(&env));
- SCOPED_TIMER(_open_scanner_time);
+ MonotonicStopWatch _watch;
Review Comment:
same suggestion for others
##########
fe/fe-core/src/main/java/org/apache/doris/common/profile/SummaryProfile.java:
##########
@@ -399,6 +415,15 @@ public void update(Map<String, String> summaryInfo) {
updateExecutionSummaryProfile();
}
+ public void queryFinished() {
+ executionSummaryProfile.addInfoString(
+ SPLITS_ASSIGNMENT_WEIGHT,
+ new
GsonBuilder().disableHtmlEscaping().create().toJson(splitWeightProfileInfoMap));
+ executionSummaryProfile.addInfoString(
+ SPLITS_ASSIGNMENT_SPLIT_INFO,
+ new
GsonBuilder().disableHtmlEscaping().create().toJson(splitProfileInfoMap));
Review Comment:
The number of split may be huge. It is not a good idea to print them all.
I think we can only print top 10 of them.
And also need to consider and, we'd even not save all split. Just save top
10 is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
