chuang-wang-pre commented on code in PR #49856:
URL: https://github.com/apache/doris/pull/49856#discussion_r2040563738
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java:
##########
@@ -1340,7 +1342,7 @@ public static Map<String, String>
analyzeBackendTagsProperties(Map<String, Strin
if (keyParts.length != 2) {
continue;
}
- String val = entry.getValue().replaceAll(" ", "");
+ String val = entry.getValue().replace(" ", "");
Review Comment:
> Please explain the reason.
If the first argument is not a real regular expression, String::replace does
exactly the same thing as String::replaceAll without the performance drawback
of the regex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
