CalvinKirs opened a new pull request, #50031:
URL: https://github.com/apache/doris/pull/50031
## Background
Previously, all storage-related property conversions were handled in a
single class: PropertyConvert. This class included logic for multiple
components such as:
- BE storage configuration
- Frontend (FE) object storage
- HDFS（FE） configuration
Over time, this approach introduced several problems:
Tight Coupling: Different storage types (e.g., S3, OSS, COS, HDFS) were
processed in a mixed manner.
Inconsistent Behavior: The same storage type behaved differently across
components. For instance:
Some services accepted https:// style URIs.
Others only accepted s3:// style URIs.
High Maintenance Cost: Adding or updating logic for a single storage type
risked breaking unrelated paths.
Low Extensibility: Introducing new storage types or protocols required
invasive changes to centralized logic.
## Changed
This PR refactors the property conversion logic with the following goals:
### Separation of Responsibility:
Each storage type (e.g., S3, COS, HDFS) now manages its own property parsing
and conversion.
No cross-dependency between different storage implementations.
### Unified Interface for Upper Layers:
A single unified interface is exposed to business logic (e.g., generating
properties for BE).
Upper layers no longer care about the specific storage type or URI scheme.
### Consistent Behavior Across Components:
Each storage implementation defines its own rules.
Eliminates inconsistencies like accepting different URI styles in different
parts of the system.
### Future-Friendly Design:
Lays the groundwork for plugin-based SPI support.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
