HappenLee commented on code in PR #49944:
URL: https://github.com/apache/doris/pull/49944#discussion_r2048200786


##########
be/src/vec/exec/format/orc/vorc_reader.h:
##########
@@ -206,6 +210,17 @@ class OrcReader : public GenericReader {
     static TypeDescriptor convert_to_doris_type(const orc::Type* orc_type);
     static std::string get_field_name_lower_case(const orc::Type* orc_type, 
int pos);
 
+    void set_read_one_line(uint64_t row_number) {

Review Comment:
   the code should be a func impl in `GenericReader`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to