morrySnow commented on code in PR #50791:
URL: https://github.com/apache/doris/pull/50791#discussion_r2083748486
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -6116,14 +6116,15 @@ public LogicalPlan
visitShowConvertLsc(ShowConvertLscContext ctx) {
@Override
public LogicalPlan visitKillQuery(KillQueryContext ctx) {
Review Comment:
> No, there are 2 ways to kill query:
>
> 1. Kill query by query id: `KILL QUERY "query_id";`
> 2. Kill query by connection id: `KILL QUERY connection_id`, where
connection_id is an integer, not a string.
the grammer is very weird. `KILL QUERY` but need a params of connection_id.
could lead to misunderstand for people not read doc very carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
