englefly commented on code in PR #11299:
URL: https://github.com/apache/doris/pull/11299#discussion_r933699230
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/PushPredicateThroughJoin.java:
##########
@@ -122,15 +121,14 @@ private Plan pushDownPredicate(LogicalJoin<GroupPlan,
GroupPlan> joinPlan,
Expression left = ExpressionUtils.and(leftPredicates);
Expression right = ExpressionUtils.and(rightPredicates);
//todo expr should optimize again using expr rewrite
- ExpressionRuleExecutor exprRewriter = new ExpressionRuleExecutor();
Plan leftPlan = joinPlan.left();
Plan rightPlan = joinPlan.right();
if (!left.equals(BooleanLiteral.TRUE)) {
- leftPlan = new LogicalFilter(exprRewriter.rewrite(left), leftPlan);
+ leftPlan = new LogicalFilter(left, leftPlan);
Review Comment:
the title is "normalize expression before rewriting", but here we remove
normalizing stop before rewriting. Could you explain the reason for this
change, please?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/BinaryExpression.java:
##########
@@ -23,15 +23,4 @@
* Interface for all expression that have two children.
*/
public interface BinaryExpression extends BinaryNode<Expression, Expression,
Expression> {
Review Comment:
Do we still need this interface if all the functions declarations are
removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
