yiguolei commented on code in PR #51265:
URL: https://github.com/apache/doris/pull/51265#discussion_r2108303333
##########
be/src/vec/data_types/serde/data_type_array_serde.cpp:
##########
@@ -271,29 +271,31 @@ void
DataTypeArraySerDe::read_one_cell_from_jsonb(IColumn& column, const JsonbVa
column.deserialize_and_insert_from_arena(blob->getBlob());
}
-void DataTypeArraySerDe::write_column_to_arrow(const IColumn& column, const
NullMap* null_map,
- arrow::ArrayBuilder*
array_builder, int64_t start,
- int64_t end, const
cctz::time_zone& ctz) const {
+Status DataTypeArraySerDe::write_column_to_arrow(const IColumn& column, const
NullMap* null_map,
+ arrow::ArrayBuilder*
array_builder, int64_t start,
+ int64_t end, const
cctz::time_zone& ctz) const {
const auto& array_column = static_cast<const ColumnArray&>(column);
const auto& offsets = array_column.get_offsets();
const auto& nested_data = array_column.get_data();
auto& builder = assert_cast<arrow::ListBuilder&>(*array_builder);
auto* nested_builder = builder.value_builder();
for (size_t array_idx = start; array_idx < end; ++array_idx) {
if (null_map && (*null_map)[array_idx]) {
- checkArrowStatus(builder.AppendNull(), column.get_name(),
Review Comment:
直接在这个外面套return if error 更好一些
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
