HappenLee commented on code in PR #11461:
URL: https://github.com/apache/doris/pull/11461#discussion_r937320284
##########
be/src/vec/exec/vaggregation_node.cpp:
##########
@@ -897,7 +963,40 @@ Status
AggregationNode::_pre_agg_with_serialized_key(doris::vectorized::Block* i
return Status::OK();
}
+Status AggregationNode::_execute_with_serialized_key_limited(Block* block) {
+ SCOPED_TIMER(_build_timer);
Review Comment:
We should use templates to abstract the code of this part of the function to
reduce the appearance of duplicate code
like
```
<bool limit>
_execute_with_serialized_key(Block* block)
```
use limit to check whether to do `find` or `emplace`
##########
be/src/vec/exec/vaggregation_node.cpp:
##########
@@ -1112,7 +1215,55 @@ Status
AggregationNode::_serialize_with_serialized_key_result(RuntimeState* stat
return Status::OK();
}
+Status AggregationNode::_merge_with_serialized_key_limited(Block* block) {
+ SCOPED_TIMER(_merge_timer);
Review Comment:
same to the update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
