This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch dev-1.1.2
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/dev-1.1.2 by this push:
new a1483d0575 [minor](log) add a warn log to observer invalid query
profile (#11588)
a1483d0575 is described below
commit a1483d0575ec3e93c57b5ce59071ff7218eef594
Author: Mingyu Chen <[email protected]>
AuthorDate: Tue Aug 9 14:10:03 2022 +0800
[minor](log) add a warn log to observer invalid query profile (#11588)
I try to fix the bug in #10095. the error occurred when I first create a
empty table and query it.
But I can't reproduced it again.
So I add a warn log here to observer
---
.../java/org/apache/doris/common/profile/ProfileTreeBuilder.java | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/common/profile/ProfileTreeBuilder.java
b/fe/fe-core/src/main/java/org/apache/doris/common/profile/ProfileTreeBuilder.java
index d810e02fd1..da621b3d6a 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/common/profile/ProfileTreeBuilder.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/common/profile/ProfileTreeBuilder.java
@@ -31,6 +31,8 @@ import com.google.common.collect.Maps;
import org.apache.commons.lang3.tuple.ImmutableTriple;
import org.apache.commons.lang3.tuple.Triple;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import java.util.Formatter;
import java.util.List;
@@ -48,6 +50,7 @@ import java.util.regex.Pattern;
* Each runtime profile of a query should be built once and be read every
where.
*/
public class ProfileTreeBuilder {
+ private static final Logger LOG =
LogManager.getLogger(ProfileTreeBuilder.class);
private static final String PROFILE_NAME_DATA_STREAM_SENDER =
"DataStreamSender";
private static final String PROFILE_NAME_VDATA_STREAM_SENDER =
"VDataStreamSender";
@@ -227,6 +230,12 @@ public class ProfileTreeBuilder {
}
}
if (senderNode == null || execNode == null) {
+ // TODO(cmy): This shouldn't happen, but there are sporadic
errors. So I add a log to observe this error.
+ // Issue: https://github.com/apache/doris/issues/10095
+ StringBuilder sb = new StringBuilder();
+ instanceProfile.prettyPrint(sb, "");
+ LOG.warn("Invalid instance profile, sender is null: {}, execNode
is null: {}, instance profile: {}",
+ (senderNode == null), (execNode == null), sb.toString());
throw new UserException("Invalid instance profile, without sender
or exec node: " + instanceProfile);
}
senderNode.addChild(execNode);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
