mrhhsg commented on code in PR #11631:
URL: https://github.com/apache/doris/pull/11631#discussion_r941933100
##########
be/src/olap/like_column_predicate.h:
##########
@@ -45,33 +47,115 @@ class LikeColumnPredicate : public ColumnPredicate {
return Status::OK();
}
+ uint16_t evaluate(const vectorized::IColumn& column, uint16_t* sel,
+ uint16_t size) const override;
+
+ void evaluate_and_vec(const vectorized::IColumn& column, uint16_t size,
+ bool* flags) const override;
+
private:
template <bool is_nullable>
void _base_evaluate(const ColumnBlock* block, uint16_t* sel, uint16_t*
size) const {
uint16_t new_size = 0;
- for (uint16_t i = 0; i < *size; ++i) {
- uint16_t idx = sel[i];
- sel[new_size] = idx;
- const StringValue* cell_value =
- reinterpret_cast<const
StringValue*>(block->cell(idx).cell_ptr());
- doris_udf::StringVal target;
- cell_value->to_string_val(&target);
- if constexpr (is_nullable) {
- new_size += _opposite ^ (!block->cell(idx).is_null() &&
- (_state->function)(_fn_ctx, target,
pattern).val);
- } else {
- new_size += _opposite ^ (_state->function)(_fn_ctx, target,
pattern).val;
+ if constexpr (!is_vectorized) {
+ for (uint16_t i = 0; i < *size; ++i) {
+ uint16_t idx = sel[i];
+ sel[new_size] = idx;
+ const StringValue* cell_value =
+ reinterpret_cast<const
StringValue*>(block->cell(idx).cell_ptr());
+ doris_udf::StringVal target;
+ cell_value->to_string_val(&target);
+ if constexpr (is_nullable) {
+ new_size += _opposite ^ (!block->cell(idx).is_null() &&
+ (_state->function)(_fn_ctx,
target, pattern).val);
+ } else {
+ new_size += _opposite ^ (_state->function)(_fn_ctx,
target, pattern).val;
+ }
}
}
*size = new_size;
}
+ template <bool is_and>
+ void _evaluate_vec(const vectorized::IColumn& column, uint16_t size, bool*
flags) const {
+ if constexpr (is_vectorized) {
+ if (column.is_nullable()) {
+ auto* nullable_col =
+
vectorized::check_and_get_column<vectorized::ColumnNullable>(column);
+ auto& null_map_data =
nullable_col->get_null_map_column().get_data();
+ auto& nested_col = nullable_col->get_nested_column();
+ if (nested_col.is_column_dictionary()) {
+ auto* nested_col_ptr = vectorized::check_and_get_column<
+
vectorized::ColumnDictionary<vectorized::Int32>>(nested_col);
+ auto& data_array = nested_col_ptr->get_data();
+ for (uint16_t i = 0; i < size; i++) {
+ if (null_map_data[i]) {
+ if constexpr (is_and) {
+ flags[i] &= _opposite;
+ } else {
+ flags[i] = _opposite;
+ }
+ continue;
+ }
+
+ StringValue cell_value =
nested_col_ptr->get_value(data_array[i]);
+ if constexpr (is_and) {
+ unsigned char flag = 0;
+ (_state->function)(
+
const_cast<vectorized::LikeSearchState*>(&_like_state),
+ cell_value, pattern, &flag);
+ flags[i] &= _opposite ^ flag;
+ } else {
+ unsigned char flag = 0;
+ (_state->function)(
+
const_cast<vectorized::LikeSearchState*>(&_like_state),
+ cell_value, pattern, &flag);
+ flags[i] = _opposite ^ flag;
+ }
+ }
+ } else {
+ LOG(FATAL) << "vectorized (not) like predicates should be
dict column";
+ }
+ } else {
+ if (column.is_column_dictionary()) {
+ auto* nested_col_ptr = vectorized::check_and_get_column<
+
vectorized::ColumnDictionary<vectorized::Int32>>(column);
+ auto& data_array = nested_col_ptr->get_data();
+ for (uint16_t i = 0; i < size; i++) {
+ StringValue cell_value =
nested_col_ptr->get_value(data_array[i]);
+ if constexpr (is_and) {
+ unsigned char flag = 0;
+ (_state->function)(
+
const_cast<vectorized::LikeSearchState*>(&_like_state),
+ cell_value, pattern, &flag);
+ flags[i] &= _opposite ^ flag;
+ } else {
+ unsigned char flag = 0;
+ (_state->function)(
+
const_cast<vectorized::LikeSearchState*>(&_like_state),
+ cell_value, pattern, &flag);
+ flags[i] = _opposite ^ flag;
+ }
+ }
+ } else {
+ LOG(FATAL) << "vectorized (not) like predicates should be
dict column";
+ }
+ }
+ }
+ }
+
std::string _origin;
// life time controlled by scan node
doris_udf::FunctionContext* _fn_ctx;
- doris_udf::StringVal pattern;
+ using PatternType = std::conditional_t<is_vectorized, StringValue,
StringVal>;
Review Comment:
This confusion will be resolved after we remove the non-vectorized code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
