morrySnow commented on code in PR #11842:
URL: https://github.com/apache/doris/pull/11842#discussion_r956988979
##########
fe/fe-core/src/main/java/org/apache/doris/planner/ExchangeNode.java:
##########
@@ -94,8 +96,15 @@ public boolean isMergingExchange() {
@Override
public final void computeTupleIds() {
- clearTupleIds();
- tupleIds.addAll(getChild(0).getTupleIds());
+ PlanNode inputNode = getChild(0);
+ TupleDescriptor outputTupleDesc = inputNode.getOutputTupleDesc();
+ if (outputTupleDesc != null) {
Review Comment:
add comment to explain it
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/ExpressionTranslator.java:
##########
@@ -258,9 +258,10 @@ public Expr visitBoundFunction(BoundFunction function,
PlanTranslatorContext con
@Override
public Expr visitBinaryArithmetic(BinaryArithmetic binaryArithmetic,
PlanTranslatorContext context) {
- return new ArithmeticExpr(binaryArithmetic.getLegacyOperator(),
+ ArithmeticExpr arithmeticExpr = new
ArithmeticExpr(binaryArithmetic.getLegacyOperator(),
Review Comment:
```suggestion
return new ArithmeticExpr(binaryArithmetic.getLegacyOperator(),
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Expression.java:
##########
@@ -45,7 +44,9 @@ public abstract class Expression extends
AbstractTreeNode<Expression> {
private static final String INPUT_CHECK_ERROR_MESSAGE = "argument %d
requires %s type, however '%s' is of %s type";
- private final Logger logger = LoggerFactory.getLogger(this.getClass());
+ protected Function function;
Review Comment:
remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
