freemandealer commented on code in PR #54363:
URL: https://github.com/apache/doris/pull/54363#discussion_r2257547210
##########
be/src/io/cache/block_file_cache_downloader.cpp:
##########
@@ -285,6 +287,7 @@ void FileCacheBlockDownloader::download_segment_file(const
DownloadFileMeta& met
g_file_cache_download_failed_num << 1;
return;
}
+ task_offset += size;
Review Comment:
yes, I also noticed that and I found they are actually the same value by any
means. you can see the size is used to update all the stats. bytes_read here is
only used for the read at API so I left it alone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
