xinyiZzz commented on code in PR #12281:
URL: https://github.com/apache/doris/pull/12281#discussion_r964853955
##########
be/src/vec/exec/scan/new_olap_scan_node.cpp:
##########
@@ -36,6 +36,7 @@ NewOlapScanNode::NewOlapScanNode(ObjectPool* pool, const
TPlanNode& tnode,
}
Status NewOlapScanNode::prepare(RuntimeState* state) {
+ SCOPED_CONSUME_MEM_TRACKER(mem_tracker());
Review Comment:
`SCOPED_CONSUME_MEM_TRACKER(mem_tracker());` should be after
`VScanNode::prepare`
_mem_tracker is initialized in `VScanNode::prepare -> ExecNode::prepare`,
##########
be/src/vec/exec/scan/vscan_node.cpp:
##########
@@ -73,7 +74,6 @@ Status VScanNode::init(const TPlanNode& tnode, RuntimeState*
state) {
Status VScanNode::prepare(RuntimeState* state) {
RETURN_IF_ERROR(ExecNode::prepare(state));
- SCOPED_CONSUME_MEM_TRACKER(mem_tracker());
Review Comment:
should not be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
