qidaye commented on code in PR #12401:
URL: https://github.com/apache/doris/pull/12401#discussion_r965604625
##########
fe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/EsUtil.java:
##########
@@ -358,22 +358,23 @@ public static List<Column> genColumnsFromEs(EsRestClient
client, String indexNam
List<Column> columns = new ArrayList<>();
for (String key : keys) {
JSONObject field = (JSONObject) mappingProps.get(key);
+ Type type;
// Complex types are not currently supported.
Review Comment:
```suggestion
// Complex types are treating as STRING types for now.
```
##########
fe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/MappingPhase.java:
##########
@@ -119,6 +119,8 @@ private static void resolveDocValuesFields(SearchContext
searchContext, JSONObje
if (!docValue) {
return;
}
+ } else if (fieldType == null) {
Review Comment:
Add some comments to explain why we need this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
