cambyzju commented on code in PR #12293:
URL: https://github.com/apache/doris/pull/12293#discussion_r965855818
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -410,18 +410,33 @@ Status ArrayFileColumnIterator::next_batch(size_t* n,
ColumnBlockView* dst, bool
ColumnBlock* array_block = dst->column_block();
auto* array_batch =
static_cast<ArrayColumnVectorBatch*>(array_block->vector_batch());
- // 1. read n offsets
+ // 1. read n+1 offsets
+ array_batch->offsets()->resize(*n + 1);
ColumnBlock offset_block(array_batch->offsets(), nullptr);
- ColumnBlockView offset_view(&offset_block,
- dst->current_offset() + 1); //
offset应该比collection的游标多1
+ ColumnBlockView offset_view(&offset_block);
Review Comment:
first element of offsets is always zero, should we still need to read?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
