Kikyou1997 commented on code in PR #12461:
URL: https://github.com/apache/doris/pull/12461#discussion_r969266049
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalRelation.java:
##########
@@ -125,4 +132,7 @@ public List<Long> getSelectedPartitionIds() {
return selectedPartitionIds;
}
+ public RelationId getId() {
Review Comment:
If this method is common for both logical and physical scan, you'd better to
an declaration in the `Scan` interface
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalRelation.java:
##########
@@ -125,4 +132,7 @@ public List<Long> getSelectedPartitionIds() {
return selectedPartitionIds;
}
+ public RelationId getId() {
Review Comment:
If this method is common for both logical and physical scan, you'd better to
add an declaration in the `Scan` interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
