kaka11chen opened a new pull request, #55346:
URL: https://github.com/apache/doris/pull/55346

   ### What problem does this PR solve?
   
   Related PR: #53729
   
   Problem Summary:
   
   runtime error: member access within null pointer of type 'FileReaderStats' 
in `TracingFileReader`
   ```
   
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/io/fs/tracing_file_reader.h:34:9:
 runtime error: member access within null pointer of type 'FileReaderStats'
       #0 0x55c028481ace in doris::io::TracingFileReader::read_at_impl(unsigned 
long, doris::Slice, unsigned long*, doris::io::IOContext const*) 
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/io/fs/tracing_file_reader.h:34:9
       #1 0x55c00922a1f7 in doris::io::FileReader::read_at(unsigned long, 
doris::Slice, unsigned long*, doris::io::IOContext const*) 
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/io/fs/file_reader.cpp:34:17
       #2 0x55c028ae8a18 in 
doris::vectorized::parse_thrift_footer(std::shared_ptr<doris::io::FileReader>, 
doris::vectorized::FileMetaData**, unsigned long*, doris::io::IOContext*) 
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/vec/exec/format/parquet/parquet_thrift_util.h:44:5
       #3 0x55c028ae8a18 in doris::vectorized::ParquetReader::_open_file() 
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/vec/exec/format/parquet/vparquet_reader.cpp:234:21
       #4 0x55c028aeb69c in 
doris::vectorized::ParquetReader::init_reader(std::vector<std::__cxx11::basic_string<char,
 std::char_traits<char>, std::allocator<char>>, 
std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, 
std::allocator<char>>>> const&, 
std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, 
std::allocator<char>>, 
std::variant<doris::ColumnValueRange<(doris::PrimitiveType)3>, 
doris::ColumnValueRange<(doris::PrimitiveType)4>, 
doris::ColumnValueRange<(doris::PrimitiveType)5>, 
doris::ColumnValueRange<(doris::PrimitiveType)6>, 
doris::ColumnValueRange<(doris::PrimitiveType)7>, 
doris::ColumnValueRange<(doris::PrimitiveType)36>, 
doris::ColumnValueRange<(doris::PrimitiveType)37>, 
doris::ColumnValueRange<(doris::PrimitiveType)15>, 
doris::ColumnValueRange<(doris::PrimitiveType)10>, 
doris::ColumnValueRange<(doris::PrimitiveType)23>, 
doris::ColumnValueRange<(doris::PrimitiveType)11>, 
doris::ColumnValueRange<(doris::PrimitiveType)25>, doris::Co
 lumnValueRange<(doris::PrimitiveType)12>, 
doris::ColumnValueRange<(doris::PrimitiveType)26>, 
doris::ColumnValueRange<(doris::PrimitiveType)20>, 
doris::ColumnValueRange<(doris::PrimitiveType)2>, 
doris::ColumnValueRange<(doris::PrimitiveType)19>, 
doris::ColumnValueRange<(doris::PrimitiveType)28>, 
doris::ColumnValueRange<(doris::PrimitiveType)29>, 
doris::ColumnValueRange<(doris::PrimitiveType)30>, 
doris::ColumnValueRange<(doris::PrimitiveType)35>>, 
std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, 
std::allocator<char>>>, std::equal_to<std::__cxx11::basic_string<char, 
std::char_traits<char>, std::allocator<char>>>, 
std::allocator<std::pair<std::__cxx11::basic_string<char, 
std::char_traits<char>, std::allocator<char>> const, 
std::variant<doris::ColumnValueRange<(doris::PrimitiveType)3>, 
doris::ColumnValueRange<(doris::PrimitiveType)4>, 
doris::ColumnValueRange<(doris::PrimitiveType)5>, 
doris::ColumnValueRange<(doris::PrimitiveType)6>, 
doris::ColumnValueRange<(doris::Primi
 tiveType)7>, doris::ColumnValueRange<(doris::PrimitiveType)36>, 
doris::ColumnValueRange<(doris::PrimitiveType)37>, 
doris::ColumnValueRange<(doris::PrimitiveType)15>, 
doris::ColumnValueRange<(doris::PrimitiveType)10>, 
doris::ColumnValueRange<(doris::PrimitiveType)23>, 
doris::ColumnValueRange<(doris::PrimitiveType)11>, 
doris::ColumnValueRange<(doris::PrimitiveType)25>, 
doris::ColumnValueRange<(doris::PrimitiveType)12>, 
doris::ColumnValueRange<(doris::PrimitiveType)26>, 
doris::ColumnValueRange<(doris::PrimitiveType)20>, 
doris::ColumnValueRange<(doris::PrimitiveType)2>, 
doris::ColumnValueRange<(doris::PrimitiveType)19>, 
doris::ColumnValueRange<(doris::PrimitiveType)28>, 
doris::ColumnValueRange<(doris::PrimitiveType)29>, 
doris::ColumnValueRange<(doris::PrimitiveType)30>, 
doris::ColumnValueRange<(doris::PrimitiveType)35>>>>> const*, 
std::vector<std::shared_ptr<doris::vectorized::VExprContext>, 
std::allocator<std::shared_ptr<doris::vectorized::VExprContext>>> const&, 
doris::TupleDescriptor
  const*, doris::RowDescriptor const*, 
std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, 
std::allocator<char>>, int, std::hash<std::__cxx11::basic_string<char, 
std::char_traits<char>, std::allocator<char>>>, 
std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, 
std::allocator<char>>>, 
std::allocator<std::pair<std::__cxx11::basic_string<char, 
std::char_traits<char>, std::allocator<char>> const, int>>> const*, 
std::vector<std::shared_ptr<doris::vectorized::VExprContext>, 
std::allocator<std::shared_ptr<doris::vectorized::VExprContext>>> const*, 
std::unordered_map<int, 
std::vector<std::shared_ptr<doris::vectorized::VExprContext>, 
std::allocator<std::shared_ptr<doris::vectorized::VExprContext>>>, 
std::hash<int>, std::equal_to<int>, std::allocator<std::pair<int const, 
std::vector<std::shared_ptr<doris::vectorized::VExprContext>, 
std::allocator<std::shared_ptr<doris::vectorized::VExprContext>>>>>> const*, 
std::shared_ptr<doris::vectorized::TableSch
 emaChangeHelper::Node>, bool) 
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/vec/exec/format/parquet/vparquet_reader.cpp:318:5
       #5 0x55c00cceda85 in doris::PushBrokerReader::_get_next_reader() 
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/olap/push_handler.cpp:671:39
       #6 0x55c00cce72df in 
doris::PushBrokerReader::next(doris::vectorized::Block*) 
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/olap/push_handler.cpp:434:9
       #7 0x55c00cce27b3 in 
doris::PushHandler::_convert_v2(std::shared_ptr<doris::Tablet>, 
std::shared_ptr<doris::Rowset>*, std::shared_ptr<doris::TabletSchema>, 
doris::PushType) 
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/olap/push_handler.cpp:293:31
       #8 0x55c00ccdd92d in 
doris::PushHandler::_do_streaming_ingestion(std::shared_ptr<doris::Tablet>, 
doris::TPushReq const&, doris::PushType, std::vector<doris::TTabletInfo, 
std::allocator<doris::TTabletInfo>>*) 
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/olap/push_handler.cpp:199:11
       #9 0x55c00ccd96f3 in 
doris::PushHandler::process_streaming_ingestion(std::shared_ptr<doris::Tablet>, 
doris::TPushReq const&, doris::PushType, std::vector<doris::TTabletInfo, 
std::allocator<doris::TTabletInfo>>*) 
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/olap/push_handler.cpp:94:11
       #10 0x55c00cccff9c in doris::EngineBatchLoadTask::_push(doris::TPushReq 
const&, std::vector<doris::TTabletInfo, std::allocator<doris::TTabletInfo>>*) 
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/olap/task/engine_batch_load_task.cpp:293:28
       #11 0x55c00cccbbc3 in doris::EngineBatchLoadTask::_process() 
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/olap/task/engine_batch_load_task.cpp:249:18
       #12 0x55c00ccc6851 in doris::EngineBatchLoadTask::execute() 
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/olap/task/engine_batch_load_task.cpp:83:22
       #13 0x55c0090293eb in doris::push_callback(doris::StorageEngine&, 
doris::TAgentTaskRequest const&) 
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/agent/task_worker_pool.cpp:1880:31
       #14 0x55c008ff6554 in doris::PriorTaskWorkerPool::normal_loop() 
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/agent/task_worker_pool.cpp:687:9
       #15 0x55c00db29237 in doris::Thread::supervise_thread(void*) 
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/util/thread.cpp:498:5
       #16 0x7fa0651f2ac2 in start_thread nptl/pthread_create.c:442:8
       #17 0x7fa06528484f  misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
   ```
   
   ### Release note
   
   Fix tracing file reader nullptr issue in push handler, releated PR: #53729.
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to