BiteTheDDDDt commented on code in PR #12684:
URL: https://github.com/apache/doris/pull/12684#discussion_r973538566
##########
be/src/exec/base_scanner.cpp:
##########
@@ -178,6 +178,11 @@ Status BaseScanner::init_expr_ctxes() {
if (_src_slot_it == std::end(src_slot_desc_map)) {
return Status::InternalError("No src slot {} in src slot
descs", it1->second);
}
+ auto src_slot_index = std::find(_src_slot_descs.cbegin(),
_src_slot_descs.cend(),
Review Comment:
Maybe we can maintain a map represent <slot_id -> slot_index>, to prevent
find desc in vector everytime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
